-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new SLE 12/15's rule package_rcpbind_removed #9931
Added a new SLE 12/15's rule package_rcpbind_removed #9931
Conversation
Hi @rumch-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
1eb0fc6
to
ce5d252
Compare
@rumch-se Can you please rebase this PR? |
ce5d252
to
2b4d3cb
Compare
2b4d3cb
to
6515e34
Compare
Code Climate has analyzed commit 6515e34 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.9% (0.0% change). View more on Code Climate. |
@rumch-se and @teacup-on-rockingchair , thanks to @dodys , a thread was started on Gitter about the package name. Could you confirm if the correct package name in SUSE is indeed |
Hello @marcusburghardt |
Ok, so we should rename the rule and its respective content. Thanks @rumch-se . |
Hello @marcusburghardt Have a nice day |
Awesome. Thanks Rumen. |
Description:
Rationale:
(Automated)
Review Hints:
Review hints here. Replace this text. Don't use the italics format!
Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.
Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.