-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accounts_password template for OL due to precedence confs #9935
Update accounts_password template for OL due to precedence confs #9935
Conversation
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Thank you @Xeicker
f2d003f
to
22df6ff
Compare
22df6ff
to
da39dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@Xeicker , the |
In Oracle Linux, when updating the options for pam_pwquality.so in system-auth it takes precedence to what was set in pwquality.conf. So this ensures that the configuration is not set in system-auth file Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
This validates the scenario when the pam_pwquality option is set in system-auth Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
da39dd2
to
46defa1
Compare
Code Climate has analyzed commit 46defa1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.8% (0.0% change). View more on Code Climate. |
Description:
system-auth
. Since that one could override the configuration present in pwquality.conf/etc/security/pwquality.conf.d/
to ensure there aren't non compliant configurations thereRationale:
Review Hints: