-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule for no .forward files #9990
Add rule for no .forward files #9990
Conversation
Hi @teacup-on-rockingchair. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@teacup-on-rockingchair: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
...uide/system/accounts/accounts-restrictions/password_storage/no_forward_files/oval/shared.xml
Outdated
Show resolved
Hide resolved
...uide/system/accounts/accounts-restrictions/password_storage/no_forward_files/oval/shared.xml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/accounts/accounts-restrictions/password_storage/no_forward_files/rule.yml
Show resolved
Hide resolved
- Thanks to @Mab879 for the review notes - Fixed copy-paste mistake used .netrc instead of .forward in oval rule - Make the regex for matching .forward file names unambigious - Add prodtype to be only sle12 and sle15, although it should work also on rhel,ol and similar
Code Climate has analyzed commit 478f10d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.9% (0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR
Automatus tests pass locally. |
Description:
Rationale:
Review Hints: