Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception when parametrized platform receives invalid argument #9996

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Raise exception when parametrized platform receives invalid argument #9996

merged 2 commits into from
Jan 4, 2023

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • when a parametrized platform receives an argumend which is not defined in corresponding shared/applicability/*.yml file, it now raises more descriptive exception
  • it also displays list of valid arguments

Rationale:

Make usage more user friendly.

@vojtapolasek vojtapolasek added Infrastructure Our content build system usability Enhancements related to usability. labels Dec 20, 2022
@vojtapolasek vojtapolasek added this to the 0.1.66 milestone Dec 20, 2022
@vojtapolasek vojtapolasek changed the title Raise exception when parametrized platforms receives invalid argument Raise exception when parametrized platform receives invalid argument Dec 20, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Dec 20, 2022

Code Climate has analyzed commit a6492cf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jan 4, 2023
jan-cerny
jan-cerny approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to use a platform package argument that doesn't exist and when I build Fedora content I got this nice exception.

@jan-cerny jan-cerny added the CPE-AL CPE Applicability Language label Jan 4, 2023
@jan-cerny jan-cerny merged commit 88b6ba7 into ComplianceAsCode:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

@matejak matejak Awaiting requested review from matejak

Assignees

@jan-cerny jan-cerny

Labels
CPE-AL CPE Applicability Language Infrastructure Our content build system usability Enhancements related to usability.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @jan-cerny