Parse built-in plugin versions from build info #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standalone plugins have the correct version because we set it with
-ldflags
when building the binary. Built-in plugins on the other hand currently report their version using a constant that we need to remember to update before every release (example). This PR makes this step unnecessary, because Conduit will overwrite the version with the version reported by go.mod.I wanted to add unit tests but
debug.BuildInfo
is not populated in tests 😕Quick checks: