Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image with downloaded prerequisites #89

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Jan 25, 2022

Changes

  • Introduced docker directory with instructions to predownload native compilers, build docker image and set ENV to use them during the tests instead of downloading compilers on-demand. This will boost our CI and also may be used for tests in dependend packages.

Commands

cd docker

# Build image
docker build -t <name>:<tag> .

# Explore image
docker run -it <name>:<tag> sh

# Publish image
docker image push <...>

Notes

  • It is still needed to decide what registry to use for uploading and hosting the image.
  • We may also introduce scripts in package.json to simplify image building and publishing steps, or consider possible automation options.

Regards.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022

CLA assistant check
All committers have signed the CLA.

@blitz-1306 blitz-1306 added the enhancement New feature or request label Jan 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #89 (fee415e) into native_compilers (e75ff29) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head fee415e differs from pull request most recent head ffd683e. Consider uploading reports for the commit ffd683e to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                  @@
##           native_compilers      #89      +/-   ##
====================================================
+ Coverage             92.16%   92.23%   +0.07%     
====================================================
  Files                   253      246       -7     
  Lines                  5179     5033     -146     
  Branches                815      800      -15     
====================================================
- Hits                   4773     4642     -131     
+ Misses                  258      249       -9     
+ Partials                148      142       -6     
Impacted Files Coverage Δ
src/ast/modern/throw_processor.ts 40.00% <0.00%> (-60.00%) ⬇️
src/ast/modern/modifier_definition_processor.ts 93.33% <0.00%> (-6.67%) ⬇️
src/ast/modern/contract_definition_processor.ts 95.00% <0.00%> (-5.00%) ⬇️
src/ast/modern/function_definition_processor.ts 95.45% <0.00%> (-4.55%) ⬇️
src/ast/modern/variable_declaration_processor.ts 91.66% <0.00%> (-4.17%) ⬇️
src/ast/ast_node_factory.ts 71.08% <0.00%> (-3.75%) ⬇️
src/compile/compiler_selection.ts 82.50% <0.00%> (-0.84%) ⬇️
src/compile/utils.ts 90.58% <0.00%> (-0.72%) ⬇️
src/types/abi.ts 80.30% <0.00%> (ø)
src/compile/index.ts 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75ff29...ffd683e. Read the comment docs.

Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from native_compilers to master February 1, 2022 09:14
@blitz-1306 blitz-1306 merged commit 9073680 into master Feb 1, 2022
@blitz-1306 blitz-1306 deleted the native_compilers-docker-manual-download branch February 1, 2022 09:15
@blitz-1306 blitz-1306 mentioned this pull request Feb 2, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants