Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predownload native compilers in CI #95

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Feb 10, 2022

Preface

This PR tweaks CI to use compiler downloading script prior to executing tests. It will help us to avoid ETXTBSY exit codes, probably caused by attempts to access compilers that are still downloading. We can reconfigure to use docker image later, when we decide where to publish it.

Changes

  • Added CI commands to predownload native compilers and set ENV to use them instead of downloading on-demand.

Notes

Part of the code, that is responsible for downloading on-demand will not be covered by the tests as the result of predownloading. Other option is to create a test that downloads only one compiler that is not used by other tests (or remove one rarely used compiler).

Regards.

@blitz-1306 blitz-1306 added the enhancement New feature or request label Feb 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #95 (2fb850f) into master (b736fb5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         254      254           
  Lines        5197     5197           
  Branches      819      819           
=======================================
  Hits         4792     4792           
  Misses        254      254           
  Partials      151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a666104...2fb850f. Read the comment docs.

Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blitz-1306 blitz-1306 merged commit adba696 into master Feb 11, 2022
@blitz-1306 blitz-1306 deleted the ci-predownload-native-compilers branch February 11, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants