-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to NodeJS 16 LTS #97
Conversation
…to WASM. Introduced CLI option --locate-compiler-cache. Updated README.
…ated README. Tweked compiler pre-downloading script and CI config.
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 91.94% 91.97% +0.02%
==========================================
Files 252 252
Lines 5165 5171 +6
Branches 817 819 +2
==========================================
+ Hits 4749 4756 +7
Misses 258 258
+ Partials 158 157 -1
Continue to review full report at Codecov.
|
… invoked. This was causing unnecessary GC cycles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work as usual! Just 2 small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes
bin
compiler distributions towasm
(as NodeJS v16 solves issues with OOMs during compiler runtime).--locate-compiler-cache
.Regards.