Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NodeJS 16 LTS #97

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Migrate to NodeJS 16 LTS #97

merged 10 commits into from
Mar 2, 2022

Conversation

blitz-1306
Copy link
Contributor

Changes

  • Migrated to NodeJS v16 LTS.
  • Switched from bin compiler distributions to wasm (as NodeJS v16 solves issues with OOMs during compiler runtime).
  • Introduced CLI option --locate-compiler-cache.
  • Updated README:
    • removed section about preinstalling 50+ compilers;
    • added section about manual invalidation of compiler cache;
    • other small tweaks and improvements.

Regards.

…to WASM. Introduced CLI option --locate-compiler-cache. Updated README.
@blitz-1306 blitz-1306 added the enhancement New feature or request label Feb 23, 2022
@blitz-1306 blitz-1306 changed the title Migrate to NodeJS 16 LTS [WIP] Migrate to NodeJS 16 LTS Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #97 (bc60c2c) into master (7e89d2e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   91.94%   91.97%   +0.02%     
==========================================
  Files         252      252              
  Lines        5165     5171       +6     
  Branches      817      819       +2     
==========================================
+ Hits         4749     4756       +7     
  Misses        258      258              
+ Partials      158      157       -1     
Impacted Files Coverage Δ
src/bin/compile.ts 89.47% <100.00%> (+0.14%) ⬆️
src/compile/kinds/compiler.ts 76.05% <100.00%> (+1.42%) ⬆️
src/compile/kinds/md.ts 76.47% <100.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e89d2e...bc60c2c. Read the comment docs.

@blitz-1306 blitz-1306 changed the title [WIP] Migrate to NodeJS 16 LTS Migrate to NodeJS 16 LTS Feb 25, 2022
Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as usual! Just 2 small nits

docker/download.sh Show resolved Hide resolved
src/compile/kinds/compiler.ts Outdated Show resolved Hide resolved
@blitz-1306 blitz-1306 requested a review from cd1m0 March 1, 2022 17:49
Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cd1m0 cd1m0 merged commit 3a5ac08 into master Mar 2, 2022
@cd1m0 cd1m0 deleted the migrate-to-nodejs-16 branch March 2, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants