Use shouldOverrideBuilder flag from engine_getPayloadV3 response #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
changed the title
tbenr
approved these changes
Jul 7, 2023
Yeah. Let's wait. Think Mikhail mentioned Monday. |
StefanBratanov
force-pushed
the
should_builder_override
branch
from
c2f12af
to
8eddc03
Compare
StefanBratanov
force-pushed
the
should_builder_override
branch
from
8eddc03
to
12e964c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implement changes as per ethereum/execution-apis#425 . Basically if flag is true coming from local EL, then local payload is used, else builder.
Also introduces
--Xuse-should-override-builder-flagwhich could turn on/off this behaviour. Default is true.Marking as draft as spec is not finalized/merged.
Fixed Issue(s)
fixes #7020
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog