One engine to rule them all #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Jul 7, 2023
| pub fn make_engine(middlewares: &[Arc<dyn ModuleMiddleware>]) -> Engine { | ||
| /// Creates an engine without a compiler. | ||
| /// This is used to run modules compiled before. | ||
| pub fn make_runtime_engine(memory_limit: Option<Size>) -> Engine { |
There was a problem hiding this comment.
Nice.
Nit: These can better live in their own engine.rs for consistency.
| @@ -35,14 +34,15 @@ pub fn main() { | |||
| println!("wasm size: {wasm_size} bytes"); | |||
|
|
|||
| // Compile module | |||
| let module = module_compile(&wasm); | |||
| let engine = make_compiling_engine(None, &[]); | |||
| let module = compile(&engine, &wasm).unwrap(); | |||
There was a problem hiding this comment.
This compile helper is now a little redundant / useless. I would say, let's either remove it, or use it everywhere instead of the explicit Module creation.
There was a problem hiding this comment.
I kept it to hide some internals in one of the examples. Not sure anymore. I use it now in all places.
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
Co-authored-by: Christoph Otter <chris@confio.gmbh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the recommendation of the Wasmer team to avoid using more engines than necessary.
We now have two main types of engines:
A few cool things happen here: