Ensure query isolation #611

alpe · 2021-09-14T07:56:22Z

Resolves #610

codecov · 2021-09-14T08:00:09Z

Codecov Report

Merging #611 (0f4c8b5) into master (454576a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   60.01%   60.04%   +0.03%     
==========================================
  Files          45       45              
  Lines        5209     5209              
==========================================
+ Hits         3126     3128       +2     
+ Misses       1860     1859       -1     
+ Partials      223      222       -1

Impacted Files	Coverage Δ
x/wasm/keeper/query_plugins.go	`78.87% <100.00%> (ø)`
x/wasm/keeper/keeper.go	`87.30% <0.00%> (+0.33%)`	⬆️

ethanfrey

Very nice, clean, minimal change providing an important safety guarantee.
I like it.

x/wasm/keeper/query_plugins.go

x/wasm/keeper/keeper_test.go

Ensure query isolation

b2d8766

alpe requested a review from ethanfrey September 14, 2021 07:56

ethanfrey approved these changes Sep 14, 2021

View reviewed changes

x/wasm/keeper/query_plugins.go Show resolved Hide resolved

x/wasm/keeper/keeper_test.go Show resolved Hide resolved

Review feedback

0f4c8b5

alpe merged commit a447ee0 into master Sep 14, 2021

alpe deleted the fix_query_isolation branch September 14, 2021 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure query isolation #611

Ensure query isolation #611

alpe commented Sep 14, 2021

codecov bot commented Sep 14, 2021 •

edited

Loading

ethanfrey left a comment

Ensure query isolation #611

Ensure query isolation #611

Conversation

alpe commented Sep 14, 2021

codecov bot commented Sep 14, 2021 • edited Loading

Codecov Report

ethanfrey left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 14, 2021 •

edited

Loading