Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SetParams #732

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Expose SetParams #732

merged 1 commit into from
Jan 24, 2022

Conversation

ethanfrey
Copy link
Member

as I will need that for migration code outside of this package

@ethanfrey ethanfrey added this to the v0.22 milestone Jan 24, 2022
@ethanfrey ethanfrey requested a review from alpe as a code owner January 24, 2022 12:46
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #732 (3acc8c9) into master (1eb27da) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   59.98%   59.95%   -0.04%     
==========================================
  Files          49       49              
  Lines        5613     5613              
==========================================
- Hits         3367     3365       -2     
- Misses       2003     2004       +1     
- Partials      243      244       +1     
Impacted Files Coverage Δ
x/wasm/keeper/genesis.go 89.61% <100.00%> (ø)
x/wasm/keeper/keeper.go 87.54% <100.00%> (-0.36%) ⬇️

Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to avoid making this public as long as possible but I guess it is time now 😢

@ethanfrey ethanfrey merged commit 74f1221 into master Jan 24, 2022
@ethanfrey ethanfrey deleted the expose-set-params branch January 24, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants