Redact query errors #775
Merged
Redact query errors #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 58.61% 58.66% +0.04%
==========================================
Files 49 49
Lines 5835 5837 +2
==========================================
+ Hits 3420 3424 +4
+ Misses 2165 2164 -1
+ Partials 250 249 -1
|
alpe
approved these changes
Mar 9, 2022
larry0x
reviewed
Aug 22, 2023
| // Otherwise redact all (we can theoretically redact less in the future) | ||
| if err != nil { | ||
| // Issue #759 - we don't return error string for worries of non-determinism | ||
| // moduleLogger(ctx).Info("Redacting submessage error", "cause", err) |
There was a problem hiding this comment.
@alpe @webmaster128 Is it possible to have this error being logged?
There was a problem hiding this comment.
No problem. I have opened an issue to track the work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #765
Closes #759