Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasmvm to v1.0.0-rc.0 #844

Merged
merged 3 commits into from
May 6, 2022
Merged

Bump wasmvm to v1.0.0-rc.0 #844

merged 3 commits into from
May 6, 2022

Conversation

alpe
Copy link
Member

@alpe alpe commented May 6, 2022

Upgrade to v1.0.0-rc.0

@alpe alpe requested a review from ethanfrey May 6, 2022 10:33
@ethanfrey
Copy link
Member

Thanks for this.

Failing linter check.

x/wasm/keeper/msg_dispatcher.go:121:14: SA1019: wasmvmtypes.SubcallResult is deprecated: Renamed to SubMsgResult (staticcheck)
var result wasmvmtypes.SubcallResult
^
can you fix? I will review and approve otherwise

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minus the linter error.

happy if you merge once ci passes

ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.0.0-beta10/libwasmvm_muslc.x86_64.a /lib/libwasmvm_muslc.x86_64.a
RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep 5b7abfdd307568f5339e2bea1523a6aa767cf57d6a8c72bc813476d790918e44
RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep 2f44efa9c6c1cda138bd1f46d8d53c5ebfe1f4a53cf3457b01db86472c4917ac
ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.0.0-rc.0/libwasmvm_muslc.aarch64.a /lib/libwasmvm_muslc.aarch64.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very important

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #844 (3936c7f) into main (0e0910e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   60.04%   60.01%   -0.04%     
==========================================
  Files          52       52              
  Lines        5972     5972              
==========================================
- Hits         3586     3584       -2     
- Misses       2119     2120       +1     
- Partials      267      268       +1     
Impacted Files Coverage Δ
x/wasm/keeper/msg_dispatcher.go 88.00% <100.00%> (ø)
x/wasm/keeper/keeper.go 87.74% <0.00%> (-0.36%) ⬇️

@alpe alpe merged commit 96a9b5a into main May 6, 2022
@alpe alpe deleted the wasmvm_upgrade branch May 6, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants