[server-1397] feedback widget system logs wordings changed. #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ar2rsawseen
reviewed
Apr 11, 2019
plugins/star-rating/api/api.js
Outdated
| @@ -66,7 +66,7 @@ var exported = {}, | |||
| common.db.collection(collectionName).insert(widget, function(err) { | |||
| if (!err) { | |||
| common.returnMessage(ob.params, 201, "Success"); | |||
| plugins.dispatch("/systemlogs", {params: params, action: "Widget added", data: widget}); | |||
| plugins.dispatch("/systemlogs", {params: params, action: "Feedback widget added", data: widget}); | |||
There was a problem hiding this comment.
Can we better have them as localized strings, so the code here would not actually change in future, but rather only localized string changes here:
https://github.com/Countly/countly-server/blob/master/plugins/systemlogs/frontend/public/localization/systemlogs.properties#L58
ar2rsawseen
requested changes
Apr 27, 2019
plugins/star-rating/api/api.js
Outdated
| @@ -2,7 +2,8 @@ var exported = {}, | |||
| common = require('../../../api/utils/common.js'), | |||
| crypto = require('crypto'), | |||
| countlyCommon = require('../../../api/lib/countly.common.js'), | |||
| plugins = require('../../pluginManager.js'); | |||
| plugins = require('../../pluginManager.js'), | |||
| localize = require('../../../api/utils/localization.js'); | |||
There was a problem hiding this comment.
Now you don't need the localization module here then :)
There was a problem hiding this comment.
yep I removed that dependencies on my last commit.
5bf4d7b
ar2rsawseen
approved these changes
Apr 30, 2019
This was referenced Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.