Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment form resubmission before server response and other payments flow improvements #157

Merged
merged 5 commits into from
Dec 10, 2013

Conversation

liuhenry
Copy link
Contributor

@liuhenry liuhenry commented Dec 7, 2013

  • Add client-generated timestamp to protect against duplicate form submissions when a user refreshes before any server response is issued (thus the PRG is never triggered)
  • Add an alert warning to the payments dialog on submit to guard against page refreshes
  • Keep track of failed payments that hit the API endpoint for hold authorization
  • Scroll to bottom of header instead of top of payment container on the payment pages to prevent any alert messages from being hidden.
  • Allow refreshing of payment confirmation page to show the message again. If user visits a different page, the confirmation page is inaccessible.

Non-feature changes:

  • The admin notification email is no longer triggered on payment after_create, so that we can save the payment in an uncompleted state to track errors and duplicate payments. This email is now explicitly called in the campaign_controller

@mattlebel
Copy link
Contributor

+1

liuhenry added a commit that referenced this pull request Dec 10, 2013
Fix payment form resubmission before server response and other payments flow improvements
@liuhenry liuhenry merged commit 9d39287 into master Dec 10, 2013
@liuhenry liuhenry deleted the payment_flow_improvements branch December 10, 2013 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants