-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free trial link in meta section of service page #510
Conversation
07f0307
to
081d978
Compare
6f4aa10
to
fa2ba25
Compare
I thought we had a style for "rel=external" that adds a little arrow to indicate "leaving this site", but it seems to have gone from everywhere (e.g. the links to CCS framework pages, the link to supplier's own site shown on the supplier dashboard). It feels like these might be a good thing if we're going to show arbitrary links on service pages. The style seems to have gone from our toolkit though. I'm going to have a quick ask round if that was a deliberate decision or something that got lost by mistake... Otherwise code looks good. |
Fix the tests. Then 👍 |
For the record here, those little arrow things went as part of wider GOV.UK style changes - there is some discussion about it here: alphagov/govuk_frontend_toolkit#293 |
@@ -3,7 +3,11 @@ <h2 class="visuallyhidden">Pricing</h2> | |||
<p class="price">{{ service.meta.price }}</p> | |||
<ul class="price-caveats"> | |||
{% for caveat in service.meta.priceCaveats %} | |||
<li>{{ caveat }}</li> | |||
<li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be an argument for using the toolkit external link style rather than baking the HTML ourselves here...
{%
with
text = caveat['text'],
link = caveat['link'],
target = "_blank"
%}
{% include "toolkit/external-link.html" %}
{% endwith %}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think that style needs an update to include the nofollow
.
fa2ba25
to
bce4223
Compare
…ne has been provided.
bce4223
to
828ac9f
Compare
Summary
In the Meta section of a service page we currently show whether or not the service offers a free trial. In G-Cloud 9 we want to turn this into a hyperlink if the supplier has provided a link to the free trial. We will also show the hyperlink provided as part of the summary table. Currently we will not turn this text into a hyperlink in the summary table, though we may do so in the future.
Ticket
https://trello.com/c/Sxd04wcI/416-free-trial-text-becomes-a-link
Old (from G8)
New (from G9)