Add function to open page on fail #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing using the selenium driver (either the Chrome or Firefox browser) in the event of a fail you are likely to want to see the page where the failure occurs to help with resolving why it failed. This change covers - Adding an after hook to call `save_and_open_page` when a scenario fails as long as the driver is not poltergeist - In the same hook if the driver is poltergeist don't show a page, but close cucumber. Assumption is based on poltergiest is being used in a CI environment where fast feedback is preferred to detailed feedback
Experience has shown that should a major element of your service go down all your tests will start failing which means you can be swamped with output from `save_and_open_page`. To prevent this the change in this commit adds logic to the `after` hook to keep a global count of the number of fails, and if it hits 5 it will cause cucumber to close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing using the selenium driver (either the Chrome or Firefox browser) in the event of a fail you are likely to want to see the page where the failure occurs to help with resolving why it failed.
This change covers
save_and_open_pagewhen a scenario fails as long as the driver is not poltergeist