Add ability to set user-agent to use #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#58 This change allows users to specify the user agent a driver should use via the `config.yml`. This will only apply to the **Firefox**, **Chrome** and **PhantomJS** drivers. The changes involved taking the argument passed in and correctly configuring the underlying driver to use it. In the case of **Firefox** this involved updating the profile. For **Chrome** it was simply adding an additional flag. **PhantomJS** proved to be more of a problem. You have to add a header via **Poltergiest**, however it only last for the current session i.e test. This means before every scenario you have to keep adding it back in. This meant a new `before()` hook was added to handle this. Other changes include tests and documentation.
Cruikshanks
force-pushed
the
feature/specify-user-agent
branch
from
f6be91c
to
acab4eb
Compare
Cruikshanks
added a commit
to DEFRA/quke-example
that referenced
this pull request
Jun 9, 2017
This adds a new page that when requested, will output the details of the request. It was created as part of working on [Add ability to set user-agent to use](DEFRA/quke#60) in **Quke**. Along with it is a feature that provides an example of how you can then test a page for specific content. Admittedly not an amazing addition as an example, but it gives meaning for the page being there, and is a working example nonetheless.
Cruikshanks
added a commit
that referenced
this pull request
Jun 12, 2017
Forgot to update the version number after implementing PR #60 Add ability to set user-agent to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58
This change allows users to specify the user agent a driver should use via the
config.yml. This will only apply to the Firefox, Chrome and PhantomJS drivers.The changes involved taking the argument passed in and
correctly configuring the underlying driver to use it. In the case of
Firefox this involved updating the profile. For Chrome it was
simply adding an additional flag.
PhantomJS proved to be more of a problem. You have to add a header
via Poltergiest, however it only last for the current session i.e
test. This means before every scenario you have to keep adding it back
in.
This meant a new
before()hook was added to handle this.Other changes include tests and documentation.