Refactor some proxy logic to make code simpler #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the code I felt I could make the proxy tests clearer by using a specific proxy test `.config.yml` file rather than keep reusing the existing generic one. Also made some tweaks to how the details are passed to the drivers to resolve **Rubocop** issues found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the code I felt I could make the proxy tests clearer by using a specific proxy test
.config.ymlfile rather than keep reusing the existing generic one.Also made some tweaks to how the details are passed to the drivers to resolve Rubocop issues found.