Skip to content

v0.11.0: Stop Quke from returning 0 exit status despite passing tests (#112)

Latest
Compare
Choose a tag to compare
@timstone timstone released this 27 Apr 11:11
· 1 commit to main since this release
1f25016
https://eaflood.atlassian.net/browse/RUBY-1373

The default behaviour here is for Cucumber to exit as soon as a single test fails. We prefer to run the full suite each time, so these errors were being rescued.

However, this meant that if a test did fail, the exit status of the job would still be 0, which isn't what we want for our CI.

This PR changes the behaviour of Quke to record if a test fails, allow the test suite to proceed, and then throw the error at the end instead.

Cucumber will also call a SystemExit when the suite has finished running, or if there is some other problem with the suite. We don't want to consider the successful runs as errors or the suite will be considered "failed" every single time.