Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly minor things #281

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Mostly minor things #281

merged 3 commits into from
Apr 7, 2023

Conversation

chporter
Copy link
Contributor

@chporter chporter commented Mar 29, 2023

Changes to code:

  1. Fix an initialization error in Denit_Ceres. Add DLAG = 0.0 in SEASINIT.
  2. Modify GHG output variable names to have different variable names for end of season and daily cumulative.
  3. Also added GHG variables to differentiate units of g/ha from kg/ha.

Differences to Summary.OUT (compared to v4.8.1.6):

  1. Some N outputs are different by small amounts < 5% (generally because of output precision).
  2. Growth variables have maximum difference of 1.5% for one rice experiment (UAFD0011, trt 1).
  3. Minor differences were found for rice, cabbage (one exp, N2O only), brachiaria (very minor).

@fabiooliveira72 , I think it's good to go, but please check with your testing procedures.

@fabiooliveira72
Copy link
Contributor

Hi @chporter

I reviewed the pull request too and found the same Differences to Summary.OUT (compared to v4.8.1.6) as you.

The pull request is good.

Please let me know if you need something else.

Thank you,

Copy link
Contributor

@fabiooliveira72 fabiooliveira72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to pull request. Clean and good code!

@fabiooliveira72 fabiooliveira72 merged commit f974008 into DSSAT:develop Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants