Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing dependency preventing it to be installed #3

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

havietisov
Copy link
Contributor

buildtools is actually required for this to be installed. In environments that don't have buildtools, following error is encountered :
#2 (comment)

@havietisov havietisov changed the title Fixing missed dependency preventing it to be installed Fixing missing dependency preventing it to be installed Dec 7, 2023
@tridao tridao merged commit 84930ce into Dao-AILab:main Dec 8, 2023
@tridao
Copy link
Contributor

tridao commented Dec 8, 2023

Thanks @havietisov!

@prescod
Copy link

prescod commented Dec 8, 2023

I am skeptical about the pull request. It changes line 258 of setup.py, but the crash happens when Python tries to run lines 8, 11 and 18.

Instead, I made a pyproject.toml with this content:

[build-system]
requires = ["packaging", "torch", "setuptools", "wheel"]

This seems to install the four requirements before running setup.py.

@havietisov
Copy link
Contributor Author

I just tried it and yes, @prescod, you're correct, it doesn't work when packaging is not installed.
My request was motivated by shenanigans caused by missing "buildtools" due to which, somehow, this thing complained about missing "packaging" in environments, when "packaging" was present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants