This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
BCNM allies and multi-phase fights #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…called with a number or base entity object, pass ally flag.
…auto-completion of battlefield upon enter caused by Promathia 2nd form being "dead" when you enter. Fix issue with Prishe accepting raise.
…nction names. Stop auto-completion of battlefield because of phases. Unlock battlefield.
… ending battlefield.
…baba from bcnm mobs.
TeoTwawki
reviewed
Nov 23, 2019
| @@ -16,6 +16,9 @@ function onSpellCast(caster,target,spell) | |||
| if (target:getName() == "Prishe") then | |||
| -- CoP 8-4 Prishe | |||
| target:setLocalVar("Raise", 1) | |||
| target:entityAnimationPacket("sp00") | |||
There was a problem hiding this comment.
@teschnei wasn't that animation already being handled elsewhere when you implemented these originally?
There was a problem hiding this comment.
er, on prishe and aern's I mean , not the spell
There was a problem hiding this comment.
One of the few things I changed was moving this stuff from Prishe to the spell because she wasn't accepting the raise before. It was in onMobFight which wasn't getting called while she was dead.
There was a problem hiding this comment.
onMobFight seems like a terrible place to have it
2 tasks
TeoTwawki
approved these changes
Dec 5, 2019
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors trying to spawn allies into a battlefield and updates some renamed BCNM functions.
This includes:
Prishe and Selh'teus in Dawn
Ajido-Marujido in Moon Reading
Karababa in Shield of Diplomacy
Trion in The Heir to the Light
Volker in Where Two Paths Converge
Also addressed is an issue where multi-phase fights will trigger win conditions if the target mob isn't spawned at the start.
These fights are:
Dawn
Moon Reading
The Heir to the Light
Where Two Paths Converge
One to be Feared
The Celestial Nexus #6318
Shadow Lord #6114
Fight logic wasn't checked other than spawning allies and stopping fights from ending prematurely. Only issue is client (not server) crashes if you try to cure a dead Prishe.