-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2041][risk=no] Documentation Updates #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending updates for Justin's comments I think these documentation updates look good.
Seeing an unrelated build error since merging dev into this branch:
Looking into it. Update: related to diegomura/react-pdf#1991 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
when this commit be available in the npm ? |
@eladonline - You'll want to ask that question in https://github.com/diegomura/react-pdf instead of here. Good luck! |
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2041
This PR covers documentation updates to cover:
npm start
docker compose
test
command and a dev dependency that used it since we are testing in a more complex and comprehensive manner via actions.@react-pdf/renderer
and@react-pdf/font
to get past compilation issuesHave you read Terra's Contributing Guide lately? If not, do that first.