Dont allow users to create bandwidthLimit disruptions below 32 bytes (#…

…795) * Dont allow users to create bandwidthLimit disruptions below 32 bytes * add a unit test
DataDog · Oct 18, 2023 · 9fe0805 · 9fe0805
1 parent 72e29fe
commit 9fe0805
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/api/v1beta1/network_disruption.go b/api/v1beta1/network_disruption.go
@@ -346,6 +346,10 @@ func (s *NetworkDisruptionSpec) Validate() (retErr error) {
 		}
 	}
 
+	if s.BandwidthLimit > 0 && s.BandwidthLimit < 32 {
+		retErr = multierror.Append(retErr, fmt.Errorf("bandwidthLimits below 32 bytes are not supported"))
+	}
+
 	return multierror.Prefix(retErr, "Network:")
 }
 

diff --git a/api/v1beta1/network_disruption_test.go b/api/v1beta1/network_disruption_test.go
@@ -442,6 +442,22 @@ var _ = Describe("NetworkDisruptionSpec", func() {
 			})
 		})
 
+		Describe("test option limits", func() {
+			It("rejects bandwidthLimits below 32 bytes", func() {
+				disruptionSpec := NetworkDisruptionSpec{BandwidthLimit: 0}
+				err := disruptionSpec.Validate()
+				Expect(err).ShouldNot(HaveOccurred())
+
+				disruptionSpec.BandwidthLimit = 32
+				err = disruptionSpec.Validate()
+				Expect(err).ShouldNot(HaveOccurred())
+
+				disruptionSpec.BandwidthLimit = 16
+				err = disruptionSpec.Validate()
+				Expect(err).Should(HaveOccurred())
+			})
+		})
+
 		DescribeTable("multi error cases",
 			func(invalidPaths HTTPPaths, invalidMethods HTTPMethods, expectedErrorMessages []string) {
 				// Arrange