-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy] add kubernetes.yml -> kubelet.yaml import logic #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to add cadvisor params DataDog/integrations-core#1339, making WIP |
xvello
force-pushed
the
xvello/legacy-kubernetes
branch
from
April 17, 2018 09:06
d4b38ba
to
5aab018
Compare
xvello
force-pushed
the
xvello/legacy-kubernetes
branch
from
April 17, 2018 09:06
5aab018
to
8ffd7d0
Compare
4 tasks
mfpierre
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ☸️ 📄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extend
pkg/legacy
andagent import
command to import settings from the agent5'skubernetes.yaml
settings, enabling thekubelet
check and importing the rest in the maindatadog.yaml
configuration.Several options are deprecated, added deprecation warning during the import + updated the docs:
Logic imports cadvisor-specific
enabled_gauges
andenabled_rates
options, see DataDog/integrations-core#1339But as the default configuration ships
port: 4194
, we cannot detect if the user wants to keep cadvisor mode, or move to the new prometheus logic. The code assumes they want and print a warning giving instructions on how to enabled it back.