Use unknown tool version when env var is not set (#1345) (#1348)

DataDog · Aug 9, 2024 · 01b70b4 · 01b70b4
1 parent 1640ba7
commit 01b70b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/controllers/datadogagent/feature/enabledefault/feature.go b/controllers/datadogagent/feature/enabledefault/feature.go
@@ -477,7 +477,7 @@ func buildInstallInfoConfigMap(dda metav1.Object) *corev1.ConfigMap {
 }
 
 func getInstallInfoValue() string {
-	toolVersion := "datadog-operator"
+	toolVersion := "unknown"
 	if envVar := os.Getenv(apicommon.InstallInfoToolVersion); envVar != "" {
 		toolVersion = envVar
 	}

diff --git a/controllers/datadogagent/feature/enabledefault/feature_test.go b/controllers/datadogagent/feature/enabledefault/feature_test.go
@@ -7,9 +7,10 @@ package enabledefault
 
 import (
 	"encoding/json"
-	"github.com/google/go-cmp/cmp"
 	"testing"
 
+	"github.com/google/go-cmp/cmp"
+
 	"github.com/stretchr/testify/assert"
 	"gopkg.in/yaml.v2"
 	corev1 "k8s.io/api/core/v1"
@@ -41,7 +42,7 @@ func Test_getInstallInfoValue(t *testing.T) {
 		{
 			name:                   "Env var empty/unset (os.Getenv returns unset env var as empty string)",
 			toolVersionEnvVarValue: "",
-			expectedToolVersion:    "datadog-operator",
+			expectedToolVersion:    "unknown",
 		},
 		{
 			name:                   "Env var set",