Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs configuration defaulting #113

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

clamoriniere
Copy link
Collaborator

Signed-off-by: cedric lamoriniere cedric.lamoriniere@datadoghq.com

What does this PR do?

fix the defaulting of the ContainerCollectUsingFiles logs parameter.

Motivation

If the ContainerCollectUsingFiles parameter is the only one not default, this parameter will not be default in the LogSpec struct. Which end up with a controller crash when it try to access this value.

Additional Notes

Anything else we should know when reviewing?

Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
@clamoriniere clamoriniere added bug Something isn't working component/controller labels Jun 26, 2020
@clamoriniere clamoriniere requested a review from a team June 26, 2020 13:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #113 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   57.25%   57.23%   -0.03%     
==========================================
  Files          31       31              
  Lines        4216     4218       +2     
==========================================
  Hits         2414     2414              
- Misses       1620     1622       +2     
  Partials      182      182              
Flag Coverage Δ
#unittests 57.23% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...controller/datadogagent/datadogagent_controller.go 26.11% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8497690...fcd9b26. Read the comment docs.

@clamoriniere clamoriniere merged commit 434ae0e into master Jun 26, 2020
@clamoriniere clamoriniere added this to the v0.3 milestone Jun 29, 2020
@clamoriniere clamoriniere deleted the clamoriniere/fixLogDefaulting branch July 1, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants