Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1109] Allow label overrides for ds for DDA updates #1173

Merged
merged 2 commits into from
May 14, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented May 8, 2024

What does this PR do?

Allows node label overrides for daemonsets when updating DDAs. After creating a DDA, subsequent changes to the node agent label overrides weren't being propagated to the agent pods.

Motivation

CECO-1109

Additional Notes

Fixes #1156

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: n/a
  • Cluster Agent: n/a

Describe your test plan

See #1193 for updated fix

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added the bug Something isn't working label May 8, 2024
@khewonc khewonc added this to the v1.7.0 milestone May 8, 2024
@khewonc khewonc requested review from a team as code owners May 8, 2024 22:38
@khewonc khewonc changed the title Allow label overrides for ds for DDA updates [CECO-1109] Allow label overrides for ds for DDA updates May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 59.53%. Comparing base (6b0c7bd) to head (336944b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   59.55%   59.53%   -0.02%     
==========================================
  Files         174      174              
  Lines       21559    21592      +33     
==========================================
+ Hits        12839    12855      +16     
- Misses       7941     7958      +17     
  Partials      779      779              
Flag Coverage Δ
unittests 59.53% <39.13%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ers/datadogagent/controller_reconcile_v2_common.go 28.36% <39.13%> (+2.74%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0c7bd...336944b. Read the comment docs.

@khewonc khewonc merged commit 62b6840 into main May 14, 2024
19 checks passed
@khewonc khewonc deleted the khewonc/ds-label-override branch May 14, 2024 17:21
khewonc added a commit that referenced this pull request May 14, 2024
* Allow label overrides for ds

* Restart ds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants