Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include milliseconds in log timestamps #1198

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented May 24, 2024

What does this PR do?

Adds milliseconds to log timestamps
before

{"level":"INFO","ts":"2024-05-24T19:05:12Z","logger":"setup","msg":"Version: v1.5.0"}
{"level":"INFO","ts":"2024-05-24T19:05:12Z","logger":"setup","msg":"Build time: 2024-03-25/17:45:26"}
{"level":"INFO","ts":"2024-05-24T19:05:12Z","logger":"setup","msg":"Git Commit: 3ce57899c62d71c1443df824a64dc9424645eda6"}
{"level":"INFO","ts":"2024-05-24T19:05:12Z","logger":"setup","msg":"Go Version: go1.19.13"}

after

{"level":"INFO","ts":"2024-05-24T19:01:08.444Z","logger":"setup","msg":"Version: v1.6.0-rc.4_89818557"}
{"level":"INFO","ts":"2024-05-24T19:01:08.444Z","logger":"setup","msg":"Build time: 2024-05-24/14:51:48"}
{"level":"INFO","ts":"2024-05-24T19:01:08.444Z","logger":"setup","msg":"Git Commit: 89818557d2e58ec91a4544702808abe2c8224550"}
{"level":"INFO","ts":"2024-05-24T19:01:08.444Z","logger":"setup","msg":"Go Version: go1.19.13"}

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m requested review from a team as code owners May 24, 2024 19:06
@levan-m levan-m added this to the v1.8.0 milestone May 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@levan-m levan-m added the enhancement New feature or request label May 24, 2024
@levan-m levan-m changed the title Inlucde milliseconds in log timestamps Include milliseconds in log timestamps Jun 17, 2024
@levan-m levan-m merged commit 7b0bc43 into main Jul 9, 2024
20 of 21 checks passed
@levan-m levan-m deleted the levan-m/log-timestamp-millis branch July 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants