Add e2e tests for the remote config updater #1243
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
+ Coverage 47.14% 51.37% +4.22%
==========================================
Files 217 377 +160
Lines 18768 33608 +14840
==========================================
+ Hits 8849 17265 +8416
- Misses 9457 15447 +5990
- Partials 462 896 +434
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 167 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
test/e2e/rc_updater_test.go
Outdated
| func TestUpdaterSuite(t *testing.T) { | ||
|
|
||
| e2eParams := []e2e.SuiteOption{ | ||
| e2e.WithStackName(fmt.Sprintf("operator-kind-2%s", k8sVersion)), |
There was a problem hiding this comment.
| e2e.WithStackName(fmt.Sprintf("operator-kind-2%s", k8sVersion)), | |
| e2e.WithStackName(fmt.Sprintf("operator-kind-rc-%s", k8sVersion)), |
Can we specify rc for remote config in the stack name?
test/e2e/rc_updater_test.go
Outdated
| e2e.WithDevMode(), | ||
| } | ||
|
|
||
| // testID := uuid.NewString()[:4] |
There was a problem hiding this comment.
Is this line still needed?
| // testID := uuid.NewString()[:4] |
.gitignore
Outdated
| @@ -100,3 +100,4 @@ tags | |||
| .idea/ | |||
| # test errors | |||
| errors | |||
| go.work* | |||
There was a problem hiding this comment.
This is no longer needed in recent updates in main
config/manager/e2e-manager.yaml
Outdated
| @@ -29,6 +29,7 @@ spec: | |||
| args: | |||
| - --enable-leader-election | |||
| - --pprof | |||
| - --remoteConfigEnabled | |||
There was a problem hiding this comment.
It would be better to have this rc-specific e2e-manager.yaml as a separate file in config/manager. I'll make an update in a separate PR to support this.
There was a problem hiding this comment.
Adding support here: #1294
|
I added a commit to resolve an issue with kustomize. Problem was not a namespace deletion before running test, rather it was kustomize failing to create resources due to below error:
This commits changes how kustomize resources are overlayed. RC-specific configs are added as patch while Tests now run fine but there is now a failure in the RC
|
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
What does this PR do?
This PR adds the e2e tests for the remote config updater
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel