Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kube-openapi version #1270

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Pin kube-openapi version #1270

merged 1 commit into from
Jul 5, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Jul 3, 2024

What does this PR do?

Pin version of kube-openapi. Dependabot is installing a newer version that doesn't have some of the flags used for our current build command:

k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340

Other PRs use this version:

k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9

Seeing if pinning the version to the older one helps dependabot

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added dependencies Pull requests that update a dependency file qa/skip-qa labels Jul 3, 2024
@khewonc khewonc requested review from a team as code owners July 3, 2024 21:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (6696b45) to head (d5c026b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         241      241           
  Lines       27901    27901           
=======================================
  Hits        15317    15317           
  Misses      11713    11713           
  Partials      871      871           
Flag Coverage Δ
unittests 54.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6696b45...d5c026b. Read the comment docs.

@khewonc khewonc merged commit 89cc56b into main Jul 5, 2024
23 checks passed
@khewonc khewonc deleted the khewonc/pin-openapi-gen-version branch July 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants