Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make bundle command to include --apis-dir flag #1285

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Update make bundle command to include --apis-dir flag during the manifest generation step.

Motivation

Since upgrading operator-sdk to v1.34.1, the make bundle command's manifest generation step removes the displayName and description for some CRDs.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Run make VERSION=x.y.z LATEST_VERSION=x.y.z bundle and make sure the DatadogAgentProfile and DatadogSLO crds still have the displayName and description field under spec.customresourcedefinitions.owned in the bundle/manifests/datadog-operator.clusterserviceversion.yaml file.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@fanny-jiang fanny-jiang added this to the v1.8.0 milestone Jul 11, 2024
@fanny-jiang fanny-jiang requested a review from a team as a code owner July 11, 2024 17:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (d0f739b) to head (b845d3d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         243      243           
  Lines       28023    28023           
=======================================
  Hits        15411    15411           
  Misses      11741    11741           
  Partials      871      871           
Flag Coverage Δ
unittests 54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f739b...b845d3d. Read the comment docs.

@fanny-jiang fanny-jiang merged commit 516b1e5 into main Jul 11, 2024
21 checks passed
@fanny-jiang fanny-jiang deleted the fanny/fix-make-bundle branch July 11, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants