Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conductor] disable failure notifications for now #1314

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Disable failure notifications for now as it isn't working as expected
Also adjust the notification slack channel

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.34%. Comparing base (5b81186) to head (af19a84).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   47.34%   47.34%           
=======================================
  Files         230      230           
  Lines       22027    22027           
=======================================
  Hits        10429    10429           
  Misses      11008    11008           
  Partials      590      590           
Flag Coverage Δ
unittests 47.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b81186...af19a84. Read the comment docs.

@celenechang celenechang merged commit a38116f into main Jul 25, 2024
23 checks passed
@celenechang celenechang deleted the celene/sdp_notifs branch July 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants