Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource.Quantity to float conversion for SLOs (#1308) #1322

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Jul 25, 2024

What does this PR do?

Cherry-pick #1308

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m added enhancement New feature or request qa/skip-qa labels Jul 25, 2024
@levan-m levan-m added this to the v1.8.0 milestone Jul 25, 2024
@levan-m levan-m requested a review from a team as a code owner July 25, 2024 20:21
@levan-m levan-m added bug Something isn't working and removed qa/skip-qa enhancement New feature or request labels Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (7b3a6ed) to head (3c44b31).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.8    #1322   +/-   ##
=======================================
  Coverage   55.20%   55.21%           
=======================================
  Files         247      247           
  Lines       28383    28384    +1     
=======================================
+ Hits        15670    15671    +1     
  Misses      11827    11827           
  Partials      886      886           
Flag Coverage Δ
unittests 55.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/datadogslo/slo.go 61.38% <100.00%> (+0.38%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3a6ed...3c44b31. Read the comment docs.

@levan-m levan-m merged commit e74729a into v1.8 Jul 26, 2024
26 checks passed
@levan-m levan-m deleted the levan-m/cherry-pick-1308 branch July 26, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants