Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] small fixes for gitlab job rules #1328

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

  • Don't run test or e2e stages when triggered by Conductor
  • Don't publish main image when triggered by Conductor
  • Set automatic rollout on Conductor trigger of child k8s-datadog-agent-ops pipeline

Motivation

Trim time spent running Conductor job
Don't use e2e tests which currently error
Automatically start workload publishing without manual intervention

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (12a4dd7) to head (fdf6332).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
+ Coverage   47.36%   47.56%   +0.20%     
==========================================
  Files         230      230              
  Lines       22027    22085      +58     
==========================================
+ Hits        10432    10504      +72     
+ Misses      11005    10989      -16     
- Partials      590      592       +2     
Flag Coverage Δ
unittests 47.56% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a4dd7...fdf6332. Read the comment docs.

@celenechang celenechang merged commit 6263597 into main Jul 26, 2024
19 checks passed
@celenechang celenechang deleted the celene/nightly_auto_rollout branch July 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants