Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing mount of system-probe config in process agent and remove s6 from CLC (aligned on Helm chart) #180

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

  • Missing mount of system-probe config file causes process-agent inability to find sysprobe.sock
  • CLC is currently using S6 while init containers already runs files in cont-init.d, removing s6 to align with Helm chart.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Deploy operator with system-probe and process-agent activated, process-agent should be able to find sysprobe.sock.
CLC must sill work properly.

@vboulineau vboulineau added the bug Something isn't working label Nov 20, 2020
@vboulineau vboulineau added this to the v0.4 milestone Nov 20, 2020
@vboulineau vboulineau requested a review from a team November 20, 2020 10:23
@vboulineau vboulineau merged commit 751ed60 into master Nov 20, 2020
@vboulineau vboulineau deleted the vboulineau/fixes branch November 20, 2020 14:11
vboulineau added a commit that referenced this pull request Dec 1, 2020
vboulineau added a commit that referenced this pull request Dec 2, 2020
* Release 0.4.0-rc.1

* Fix bundle image version

* Fix default image path

* Release 0.4.0-rc.4

* Remove deprecated /deploy and /chart

* Release 0.4.0-rc.5

* Release 0.4.0-rc.6

* Fix missing mount of system-probe config in process agent and remove s6 from CLC (aligned on Helm chart) (#180)

* Fix deep equal of CRB if it already exist and is incorrect (#174)

* fix deep equal of CRB if it already exist and is incorrect

* Release 0.4.0-rc.7

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>

* Fix get-tag version

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>

* Release 0.4.0

Co-authored-by: Lénaïc Huard <lenaic.huard@datadoghq.com>
Co-authored-by: Charly Fontaine <charly@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants