-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: k8s version detection for agent service #472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
approved these changes
Apr 26, 2022
clamoriniere
force-pushed
the
clamoriniere/local-service
branch
from
April 26, 2022 14:15
2d3944d
to
2a4f1c8
Compare
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 60.60% 63.04% +2.43%
==========================================
Files 3 3
Lines 132 138 +6
==========================================
+ Hits 80 87 +7
+ Misses 40 38 -2
- Partials 12 13 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JacksonDavenport
added a commit
that referenced
this pull request
Apr 26, 2022
…v vars Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function
clamoriniere
added a commit
that referenced
this pull request
Apr 27, 2022
JacksonDavenport
added a commit
that referenced
this pull request
Apr 27, 2022
…v vars (#471) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com>
JacksonDavenport
added a commit
that referenced
this pull request
Apr 28, 2022
…v vars (#471) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com>
celenechang
pushed a commit
that referenced
this pull request
Apr 28, 2022
JacksonDavenport
added a commit
that referenced
this pull request
Apr 28, 2022
…v vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com> Co-authored-by: Celene Chang <celene@datadoghq.com>
Merged
celenechang
pushed a commit
that referenced
this pull request
May 18, 2022
celenechang
added a commit
that referenced
this pull request
May 18, 2022
…v vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com> Co-authored-by: Celene Chang <celene@datadoghq.com>
celenechang
added a commit
that referenced
this pull request
May 18, 2022
…v vars (#471) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com>
khewonc
added a commit
that referenced
this pull request
May 19, 2022
* release v0.8.0-rc.1 * [defaulting/images] Update agent to 7.35.0 (#465) * [controllers/datadogagent/utils] Fix process collection nil check (#466) * [examples] Fix datadog-agent-secret-backend (#467) * Add port names to agent service (#468) * Update default DCA image to 1.19.0 (#470) * release v0.8.0-rc.2 * fix: k8s version detection for agent service (#472) (#473) * Add NodeLabelsAsTags and NamespaceLabelsAsTags, remove default Pod env vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <celene@datadoghq.com> Co-authored-by: Celene Chang <celene@datadoghq.com> * release v0.8.0-rc.3 * Default Agent version to 7.35.2 (#480) * release v0.8.0-rc.4 * release v0.8.0 Co-authored-by: David Ortiz <david.ortiz@datadoghq.com> Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com> Co-authored-by: JacksonDavenport <jakdavenport@yahoo.com> Co-authored-by: Celene Chang <celene@datadoghq.com> Co-authored-by: Paul Cacheux <paul.cacheux@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix how we detect the Kubernetes version.
the information was already present in the reconciler.
the
manageAgentService()
function now use the informationfrom the
Reconcile
struct.Motivation
Fix how we detect the Kubernetes version to automaticaly
create the local agent service if it is supported by the
kubernetes version.
Additional Notes
Describe your test plan
deploy the operator and create the
DatadogAgent
with this manifestthe service
datadog-agent
should be created in the same namespace.