Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2alpha1] Don't skip #546

Merged
merged 2 commits into from
Jul 6, 2022
Merged

[v2alpha1] Don't skip #546

merged 2 commits into from
Jul 6, 2022

Conversation

davidor
Copy link
Member

@davidor davidor commented Jul 6, 2022

What does this PR do?

Deletes // +kubebuilder:skip from the v2alpha1 package.
This was merged unintentionally in #533

@davidor davidor requested review from a team as code owners July 6, 2022 09:57
@davidor davidor added the bug Something isn't working label Jul 6, 2022
@davidor davidor added this to the v1.0.0 milestone Jul 6, 2022
@davidor davidor merged commit 0a0decb into main Jul 6, 2022
@davidor davidor deleted the davidor/v2alpha1-dont-skip branch July 6, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celenechang celenechang celenechang approved these changes

@github-actions GitHub Actions github-actions approved these changes

@vboulineau vboulineau vboulineau approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davidor @celenechang @vboulineau