Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component/ccr] Fix default service account name #556

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

davidor
Copy link
Member

@davidor davidor commented Jul 14, 2022

What does this PR do?

Fixes the default service account name used by the cluster checks runner.

The KSM core was not working when running on the runners because they were using the wrong service account.

Describe your test plan

KSM core check should work properly when running on a cluster check runner.

@davidor davidor added the bug Something isn't working label Jul 14, 2022
@davidor davidor added this to the v1.0.0 milestone Jul 14, 2022
@davidor davidor requested review from a team as code owners July 14, 2022 11:37
@codecov-commenter
Copy link

Codecov Report

Merging #556 (61f3129) into main (2e9c140) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           3        3           
  Lines         135      135           
=======================================
  Hits           79       79           
  Misses         43       43           
  Partials       13       13           
Flag Coverage Δ
unittests 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9c140...61f3129. Read the comment docs.

@davidor davidor merged commit fffce84 into main Jul 14, 2022
@davidor davidor deleted the davidor/fix-ccr-service-account-name branch July 14, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants