-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadogagent/finalizer] Delete dependencies of V2 agents #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 3 3
Lines 135 135
=======================================
Hits 79 79
Misses 43 43
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
abef2b0
to
6c70bea
Compare
6c70bea
to
4be3dd2
Compare
Rebased on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought about it for a while and i'm ok with this approach, feels future proof.
What does this PR do?
Implements a finalizer for V2 agents. The finalizer removes all the resources associated with the agent.
Before this PR, cluster roles and cluster role bindings were not being deleted.
Describe your test plan
When deleting a V2 agent, check that its associated resources are also deleted.