Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadogagent/finalizer] Delete dependencies of V2 agents #576

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

davidor
Copy link
Member

@davidor davidor commented Jul 26, 2022

What does this PR do?

Implements a finalizer for V2 agents. The finalizer removes all the resources associated with the agent.
Before this PR, cluster roles and cluster role bindings were not being deleted.

Describe your test plan

When deleting a V2 agent, check that its associated resources are also deleted.

@davidor davidor requested review from a team as code owners July 26, 2022 13:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling

@davidor davidor added the bug Something isn't working label Jul 26, 2022
@davidor davidor added this to the v1.0.0 milestone Jul 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #576 (4be3dd2) into main (86164f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           3        3           
  Lines         135      135           
=======================================
  Hits           79       79           
  Misses         43       43           
  Partials       13       13           
Flag Coverage Δ
unittests 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86164f0...4be3dd2. Read the comment docs.

@davidor davidor changed the title [datadogagent/finalizer] Delete dependencies for V2 agents [datadogagent/finalizer] Delete dependencies of V2 agents Jul 26, 2022
@davidor
Copy link
Member Author

davidor commented Jul 27, 2022

Rebased on top of main to fix conflicts.

Copy link
Contributor

@celenechang celenechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought about it for a while and i'm ok with this approach, feels future proof.

@davidor davidor merged commit da610f1 into main Aug 31, 2022
@davidor davidor deleted the davidor/fix-finalizer-v2 branch August 31, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants