[component/clusteragent] Change anti-affinity to "preferred" #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
approved these changes
Jul 29, 2022
davidor
force-pushed
the
davidor/dca-preferred-anti-affinity
branch
from
b14ddda
to
a168cf3
Compare
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 3 3
Lines 135 135
=======================================
Hits 79 79
Misses 43 43
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the DCA anti-affinity from "required" to "preferred".
This is because when using "required" agent updates can't work on clusters with 1 node.
We're already using "preferred" in the cluster check runners.
Describe your test plan
Deploy in a cluster with one node. Make an update that affects the DCA, for example, enable/disable the orchestrator explorer feature. Check that the new DCA pod is deployed correctly.