update metrics forwarder to support v2 #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 3 3
Lines 135 135
=======================================
Hits 79 79
Misses 43 43
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
buraizu
requested changes
Aug 24, 2022
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
| // +optional | ||
| GeneratedToken string `json:"generatedToken,omitempty"` | ||
|
|
||
| // Status corresponds to the ClusterAgent deployment computed status. |
There was a problem hiding this comment.
DeploymentStatus can be use also for the clustercheckrunner so it can be good to remove the notion of ClusterAgent in the description
…-operator into celene/metrics_forwarder
buraizu
requested changes
Aug 31, 2022
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
buraizu
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Metrics Forwarder to support v2 as well as maintain support for v1 DatadogAgent.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Deploy the operator with the v1 DatadogAgent CRD enabled and set flag
operatorMetricsEnabled=true. Apply the DatadogAgent, for instanceexamples/datadogagent/datadog-agent-all.yaml. Make sure that operator metrics are reporting to Datadog.Do the same with the v2 CRD, using
examples/v2alpha1/min.yaml.