Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v2 status #607

Merged
merged 3 commits into from
Sep 2, 2022
Merged

update v2 status #607

merged 3 commits into from
Sep 2, 2022

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Small updates to v2alpha1 DatadogAgent status

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@celenechang celenechang added bug Something isn't working component/controller labels Sep 1, 2022
@celenechang celenechang added this to the v1.0.0 milestone Sep 1, 2022
@celenechang celenechang requested review from a team as code owners September 1, 2022 16:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #607 (1188d2f) into main (f337748) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           3        3           
  Lines         135      135           
=======================================
  Hits           79       79           
  Misses         43       43           
  Partials       13       13           
Flag Coverage Δ
unittests 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f337748...1188d2f. Read the comment docs.

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not link to the PR directly but, I think the conditions set at the end of the reconcile should be review.

@celenechang celenechang merged commit 37d139a into main Sep 2, 2022
@celenechang celenechang deleted the celene/v2_status branch September 2, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants