Enable V2 by default #614
Merged
Enable V2 by default #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hestonhoffman
approved these changes
Sep 16, 2022
celenechang
reviewed
Sep 20, 2022
| @@ -0,0 +1,4 @@ | |||
| # The following patches adds configure the DatadogAgents CRD to use v1alpha1 as the storage version. | |||
There was a problem hiding this comment.
Suggested change
| # The following patches adds configure the DatadogAgents CRD to use v1alpha1 as the storage version. | |
| # The following patches adds a configuration to the DatadogAgents CRD to use v1alpha1 as the storage version. |
celenechang
reviewed
Sep 20, 2022
| @@ -1,10 +1,10 @@ | |||
| # The following patches adds configure the DatadogAgents CRD to use v2alpha1 as the storage version. | |||
| # The following patches adds configure the DatadogAgents CRD to use v1alpha1 as the storage version. | |||
There was a problem hiding this comment.
Suggested change
| # The following patches adds configure the DatadogAgents CRD to use v1alpha1 as the storage version. | |
| # The following patches adds a configuration to the DatadogAgents CRD to use v1alpha1 as the storage version. |
celenechang
reviewed
Sep 20, 2022
| @@ -921,7 +921,7 @@ type DatadogAgentStatus struct { | |||
| // DatadogAgent Deployment with the Datadog Operator. | |||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:unservedversion | |||
There was a problem hiding this comment.
should we add this flag to v1alpha1?
There was a problem hiding this comment.
Added and adapted manifests, patches, etc. 👍
celenechang
reviewed
Sep 20, 2022
docs/how-to-contribute.md
Outdated
| @@ -32,18 +32,16 @@ make IMG=test/operator:test deploy | |||
|
|
|||
| Note: `IMG` currently defaults to: `datadog/datadog-operator:latest` | |||
|
|
|||
| ## \[TMP\] how to test `v2alpha` | |||
| ## Test using `v2alpha` | |||
There was a problem hiding this comment.
should we rm this section header and merge the cert manager install cmd with the section above?
davidor
force-pushed
the
davidor/enable-v2-by-default
branch
from
4ecb5b0
to
974d69a
Compare
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 3 3
Lines 135 135
=======================================
Hits 79 79
Misses 43 43
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Because it's default now.
davidor
force-pushed
the
davidor/enable-v2-by-default
branch
from
974d69a
to
340bede
Compare
Just in case we need to test something with v1.
davidor
force-pushed
the
davidor/enable-v2-by-default
branch
from
340bede
to
463975b
Compare
CharlyF
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables V2 by default. It's no longer necessary to run the commands with
KUSTOMIZE_CONFIG=config/test-v2.I've added some configs to be able to test V1 in case we need it.