Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share the system-probe socket when oom_kill or tcp_queue_length checks are enabled #644

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Nov 18, 2022

What does this PR do?

Share the system-probe socket with the core agent when the oom_kill or tcp_queue_length checks are enabled.

Motivation

This is a followup of #642 to fix the activation of oom_kill and tcp_queue_length checks.

Additional Notes

Describe your test plan

Start a datadog agent with a manifest like:

apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog
spec:
  global:
    credentials:
      apiSecret:
        secretName: datadog-secret
        keyName: api-key
      appSecret:
        secretName: datadog-secret
        keyName: app-key
  features:
    oomKill:
      enabled: true
    tcpQueueLength:
      enabled: true

and an agent version that contains DataDog/datadog-agent#14332 and check that the oom_kill and tcp_queue_length checks are correctly scheduled in the core agent.

@L3n41c L3n41c added the bug Something isn't working label Nov 18, 2022
@L3n41c L3n41c added this to the v1.0.0 milestone Nov 18, 2022
@L3n41c L3n41c requested review from a team as code owners November 18, 2022 10:22
@L3n41c L3n41c force-pushed the lenaic/fix_oom_kill_tcp_queue_length branch from 323bac1 to 1a2072b Compare November 21, 2022 09:03
@L3n41c L3n41c merged commit 8c77338 into main Nov 22, 2022
@L3n41c L3n41c deleted the lenaic/fix_oom_kill_tcp_queue_length branch November 22, 2022 10:09
khewonc pushed a commit that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants