Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makefile] Update envtest k8s version to 1.24 #646

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

davidor
Copy link
Member

@davidor davidor commented Nov 21, 2022

What does this PR do?

Updates the k8s version used by envtest to 1.24.

Motivation

envtest with 1.20 doesn't work on M1s:

unable to find a version that was supported for platform darwin/arm64

1.24 instead of 1.25 because the known issue about the Operator not working properly on 1.25.

Describe your test plan

make integration-tests-v2 should work on M1s.

@davidor davidor requested review from a team as code owners November 21, 2022 11:41
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling

@davidor davidor added this to the v1.0.0 milestone Nov 21, 2022
@davidor davidor added the enhancement New feature or request label Nov 21, 2022
@davidor davidor added tooling and removed enhancement New feature or request labels Nov 21, 2022
@davidor davidor merged commit ea93150 into main Nov 22, 2022
@davidor davidor deleted the davidor/makefile-envtest-k8s-1.24 branch November 22, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants