Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admission controller default settings panic #677

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Dec 30, 2022

What does this PR do?

Fix panic: runtime error: invalid memory address or nil pointer dereference with the following configuration:

  features:
    admissionController:
      mutateUnlabelled: true
      agentCommunicationMode: socket

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@khewonc khewonc added the bug Something isn't working label Dec 30, 2022
@khewonc khewonc added this to the v1.0.0 milestone Dec 30, 2022
@khewonc khewonc requested review from a team as code owners December 30, 2022 15:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #677 (1c930af) into main (114599e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   58.54%   58.54%           
=======================================
  Files         144      144           
  Lines       17376    17377    +1     
=======================================
+ Hits        10173    10174    +1     
  Misses       6593     6593           
  Partials      610      610           
Flag Coverage Δ
unittests 58.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/datadoghq/v2alpha1/datadogagent_default.go 87.09% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114599e...1c930af. Read the comment docs.

@CharlyF CharlyF merged commit a12f5b4 into main Jan 3, 2023
@CharlyF CharlyF deleted the khewonc/admission-controller-panic branch January 3, 2023 23:06
CharlyF pushed a commit that referenced this pull request Jan 3, 2023
@CharlyF CharlyF restored the khewonc/admission-controller-panic branch January 3, 2023 23:27
CharlyF pushed a commit that referenced this pull request Jan 4, 2023
@khewonc khewonc deleted the khewonc/admission-controller-panic branch June 21, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants