Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all fields are taken into account with NPM #678

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

CharlyF
Copy link
Contributor

@CharlyF CharlyF commented Dec 30, 2022

What does this PR do?

NPM options collectDNSStats and enableConntrackare not taken into account (converted as env vars), so we rely on the sys probe behavior, which will enable both if they are not configured. Unfortunately:

  features:
    npm:
      collectDNSStats: false
      enableConntrack: false
      enabled: true 

will result in both of them turned on.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@CharlyF CharlyF added the bug Something isn't working label Dec 30, 2022
@CharlyF CharlyF added this to the v1.0.0 milestone Dec 30, 2022
@CharlyF CharlyF requested review from a team as code owners December 30, 2022 21:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #678 (864fad3) into main (114599e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   58.54%   58.57%   +0.02%     
==========================================
  Files         144      144              
  Lines       17376    17387      +11     
==========================================
+ Hits        10173    10184      +11     
  Misses       6593     6593              
  Partials      610      610              
Flag Coverage Δ
unittests 58.57% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/feature/npm/feature.go 91.53% <100.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114599e...864fad3. Read the comment docs.

@CharlyF CharlyF merged commit 02f46cd into main Jan 3, 2023
@CharlyF CharlyF deleted the charly/fix-npm branch January 3, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants